search

kaajjo / LibreSudoku

LibreSudoku - Sudoku app for android built with Kotlin + Jetpack Compose + Material3
GNU General Public License v3.0
411 stars 31 forks source link

App strings reworked #45

Open comradekingu opened 1 year ago

comradekingu commented 1 year ago

It is unclear what "Ascending" / "Descending" refers to.

nvllz commented 1 year ago

It looks like you haven't played the game that much. Many changed strings would not fit well into the app. The most important thing is to change 'values' to 'numbers', because there's also a 12x12 grid. I think you need to perfect this PR a bit more.

comradekingu commented 1 year ago

@nvllz I'll see what I can do. Maybe you could put a little dot or an explanation of the issue next to the problematic strings? Is changing "values" to "numbers" good or bad? I don't understand what it has to do with a 12x12 grid. Mainly trying to cut back on the amount of text.