kaklakariada / fritzbox-java-api

Java API for managing FritzBox HomeAutomation
GNU General Public License v3.0
20 stars 14 forks source link

Reading objects from inputstream #53

Closed TDesjardins closed 2 years ago

TDesjardins commented 2 years ago

Currently the deserializer reads a string build from the reponse body:

https://github.com/kaklakariada/fritzbox-java-api/blob/master/src/main/java/com/github/kaklakariada/fritzbox/mapping/Deserializer.java#L41

okhttp and simple-xml both support streaming so reading an object can be made more efficient especially for larger objects.

I could provide a PR if this feature is wanted.

kaklakariada commented 2 years ago

Good idea, a pr is welcome 😁