search

kaklakariada / fritzbox-java-api

Java API for managing FritzBox HomeAutomation
GNU General Public License v3.0
20 stars 13 forks source link

datatime attribute added #58

Closed LutzHelling closed 9 months ago

LutzHelling commented 9 months ago

Hi, I've added the datatime attribute when getting the energy consumption data. This helps plotting a consumption graph with time ticks on the x-axis. I would appreciate if you could integrate this extension in your beautiful project. Thanks in advance!

kaklakariada commented 9 months ago

Hi @LutzHelling, I am not sure if the commit worked. I only see two additional merge commits in this PR, but there are no changes to the code.

LutzHelling commented 9 months ago

Hi,

I've commited to my fork only, I forgot to merge with upstream/master. I hope now it's possible to see my changes.

Have a nice weekend Lutz

On Sat, Oct 7, 2023, 08:02 Christoph Pirkl @.***> wrote:

Hi @LutzHelling https://github.com/LutzHelling, I am not sure if the commit worked. I only see two additional merge commits in this PR, but there are no changes to the code.

— Reply to this email directly, view it on GitHub https://github.com/kaklakariada/fritzbox-java-api/pull/58#issuecomment-1751613739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN5LIATWP42SIXLKQCXYDXTX6DWBDAVCNFSM6AAAAAA5RBUT4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRGYYTGNZTHE. You are receiving this because you were mentioned.Message ID: @.***>

kaklakariada commented 9 months ago

Hi @LutzHelling, the build is failing and I would like to improve the tests and handling of default values. To speedup the process I will directly edit your PR and ask you for your approval.

kaklakariada commented 9 months ago

@LutzHelling Please check my changes if this was your intention.