search

kaleido-io / kaleido-iden3-samples

Sample code for using the iden3 protocol to issue verifiable claims
Apache License 2.0
6 stars 4 forks source link

readme update #13

Closed Chengxuan closed 1 year ago

Chengxuan commented 1 year ago

Signed-off-by: Chengxuan Xing chengxuan.xing@kaleido.io

nedgar commented 1 year ago

I understand the need for exit(), just suggesting the exit code be eg 1 instead of 0 in case of error. On Jan 12, 2023 at 6:58 AM -0500, Chengxuan Xing @.***>, wrote:

@Chengxuan commented on this pull request. In holder/wallet/index.js:

 })

.catch((err) => {

  • console.error(err);
  • });
  • console.error(err.message);
  • }).finally(() => process.exit(0)); this is just there because node.js thread doesn't exist. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
Chengxuan commented 1 year ago

@nedgar I agree, if there is a need for this app to return error, the error shouldn't be swallowed by the catch block and thus exit should have an error return code.