kaleido-io / kaleido-iden3-samples

Sample code for using the iden3 protocol to issue verifiable claims
Apache License 2.0
6 stars 4 forks source link

Do not add issued user claims to the claims tree #24

Closed jimthematrix closed 1 year ago

jimthematrix commented 1 year ago

As we are using the signature based circuit for generating and verifying the zk proofs, we do not need to add the issued claims to the claims tree. This avoids the concern that the hashes of PII (included in the claims) will be uploaded to the State contract and violates regulations in certain jurisdictions (GDPR, CCPA etc.) For the background see https://github.com/kaleido-io/kaleido-iden3-samples/issues/10#issuecomment-1384624126

This also includes a workaround for tolerating the incorrect checksum by the go-iden3-core library. For the background see https://github.com/kaleido-io/kaleido-iden3-samples/issues/14#issuecomment-1382629290

nedgar commented 1 year ago

Nice!

nedgar commented 1 year ago

@jimthematrix I had come up with a different workaround for the checksum issue: use js-iden3-auth's ID.idFromInt instead of js-iden3-core's ID.fromBigInt, but js-iden3-auth doesn't actually export ID so it's a bit of a hack: const { Id } = require('@iden3/js-iden3-core/dist/cjs/core/id');