search

kalekundert / autoclasstoc

Sphinx plugin to make easier-to-navigate class documentation.
MIT License
18 stars 7 forks source link

Changes GHA workflow trigger to pull request #27

Closed funkyfuture closed 1 year ago

funkyfuture commented 2 years ago

b/c the workflow requires a token that is not available when triggered on a forked repository and thus always fails.

the part where the workflow combines a release with a successful test run is frightening indeed.

kalekundert commented 2 years ago

Only triggering on pull requests would be inconvenient for me, since I don't make PRs for my own contributions. Also, it looks like the tests still fail for forks because a secret is needed to upload coverage info. I think a better solution would be to only run the coverage/release steps on this repository, in the manner described here: https://github.com/orgs/community/discussions/26409

I just pushed a commit that should do this. If that seems to work, we can close this PR.

funkyfuture commented 2 years ago

from contributor perspective, i find tests on pull requests very useful. as a maintainer elsewhere too.

this PR doesn't try to address the token issue.

funkyfuture commented 2 years ago

this PR doesn't try to address the token issue.

meaning: as a contributor that is not of my concern, but this PR attempts to get sorted out which actor triggers which behaviour.

kalekundert commented 1 year ago

I believe that the tests will now run without error on PRs, so I'm closing this issue for now.