KeyError in the new array tests?

kalhauge / jpamb

JPAMB: Java Program Analysis Micro Benchmarks

BSD 3-Clause "New" or "Revised" License

0 stars 12 forks source link

KeyError in the new array tests? #12

Closed jayveedee closed 1 month ago

jayveedee commented 1 month ago

Attached some images of the error from the golden.log

Seems like something happens when trying to run the cases with arrays as inputs. I also looked at the cases.txt and distribution.csv and saw that the parameter for the arrays were missing the right bracket: "]". Tried fixing that but got another error instead. See images

The cases annotations in Arrays.java look fine however

This happened on my machine (Windows 11) and my group mates' machines (Mac/WIndows)

kalhauge commented 1 month ago

Hi!

The format for input and input types has evolved a bit to allow for arrays, please take a look at: https://github.com/kalhauge/jpamb/blob/72d82bb5484da052a1332fcdc8815e85da69a293/jpamb_utils/__init__.py#L59-L74 and https://github.com/kalhauge/jpamb/blob/72d82bb5484da052a1332fcdc8815e85da69a293/jpamb_utils/__init__.py#L218 for a reference for both.

kalhauge commented 1 month ago

But I also consider this a documentation issue as the README should state the format more clearly. Sorry about that.

jayveedee commented 1 month ago

What can I do to fix the issue with the KeyError then? Are the case annotations incorrect then if "[I" is correct?

kalhauge commented 1 month ago

I see that the bug is in your interpreter at line 43. I can't do anything to fix it. But instead of using your own MethodId you can use the one in the jpamb_utils.

jayveedee commented 1 month ago

Oh, I think why we're getting this error. We haven't gotten the new changes for the interpreter.py that have been added to your repo. I will fix this and close the issue if it's resolved. Thanks for the help :)