search

kaliop-uk / ezmigrationbundle

This bundle makes it easy to handle eZPlatform / eZPublish5 content upgrades/migrations
GNU General Public License v2.0
53 stars 81 forks source link

allow version 4 for nikic php-parser #167

Closed crevillo closed 6 years ago

crevillo commented 6 years ago

i'm playing with some other projects that requires this php-parser version.

do you think this could lead to some problems here? if so, please discard this.

gggeek commented 6 years ago

I would have to take a look at how we use it... The bundle iirc uses a small part of the php-parser api, and the release notes seem to be nicely detailed (https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-4.0.md), so I'd say good chances of going in as soon as I can afford a few minutes to look into it

codecov-io commented 6 years ago

Codecov Report

Merging #167 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #167   +/-   ##
=========================================
  Coverage     67.51%   67.51%           
  Complexity     2293     2293           
=========================================
  Files           120      120           
  Lines          6055     6055           
=========================================
  Hits           4088     4088           
  Misses         1967     1967

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fd6962...bc942ea. Read the comment docs.

gggeek commented 6 years ago

Ok, the usage that we do of of php-parser is minimal. Going in