Open erdnaxelaweb opened 5 years ago
Merging #203 into master will decrease coverage by
0.13%
. The diff coverage is12.5%
.
@@ Coverage Diff @@
## master #203 +/- ##
============================================
- Coverage 67.69% 67.56% -0.14%
- Complexity 2578 2585 +7
============================================
Files 123 124 +1
Lines 6714 6730 +16
============================================
+ Hits 4545 4547 +2
- Misses 2169 2183 +14
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
Core/FieldHandler/EzImageAsset.php | 12.5% <12.5%> (ø) |
7 <7> (?) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4019189...49ec65a. Read the comment docs.
Nice, thanks. Would you be able to add a test case as well? A yml migration file that creates a content type with an ezimageasset field, then a content, then removes both, in tests/dsl/ezimageasset/ would be enough - I can add the phpunit part.
I will let @mpoudevigne answer as he was the one working on this :)
@gggeek Can you say me if it's ok my kaliop migration files committed ? thanks
@mpoudevigne yes, migration files are committed ok. I hope to merge and release soon
@gggeek thanks
Add field handler for the ezplatform ezimageasset field type