kaliop-uk / ezmigrationbundle

This bundle makes it easy to handle eZPlatform / eZPublish5 content upgrades/migrations
GNU General Public License v2.0
53 stars 81 forks source link

Image asset complex field handler #203

Open erdnaxelaweb opened 5 years ago

erdnaxelaweb commented 5 years ago

Add field handler for the ezplatform ezimageasset field type

codecov-io commented 5 years ago

Codecov Report

Merging #203 into master will decrease coverage by 0.13%. The diff coverage is 12.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #203      +/-   ##
============================================
- Coverage     67.69%   67.56%   -0.14%     
- Complexity     2578     2585       +7     
============================================
  Files           123      124       +1     
  Lines          6714     6730      +16     
============================================
+ Hits           4545     4547       +2     
- Misses         2169     2183      +14
Impacted Files Coverage Δ Complexity Δ
Core/FieldHandler/EzImageAsset.php 12.5% <12.5%> (ø) 7 <7> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4019189...49ec65a. Read the comment docs.

gggeek commented 5 years ago

Nice, thanks. Would you be able to add a test case as well? A yml migration file that creates a content type with an ezimageasset field, then a content, then removes both, in tests/dsl/ezimageasset/ would be enough - I can add the phpunit part.

erdnaxelaweb commented 5 years ago

I will let @mpoudevigne answer as he was the one working on this :)

mpoudevigne commented 5 years ago

@gggeek Can you say me if it's ok my kaliop migration files committed ? thanks

gggeek commented 5 years ago

@mpoudevigne yes, migration files are committed ok. I hope to merge and release soon

mpoudevigne commented 5 years ago

@gggeek thanks