search

kaliop-uk / ezmigrationbundle

This bundle makes it easy to handle eZPlatform / eZPublish5 content upgrades/migrations
GNU General Public License v2.0
53 stars 81 forks source link

Resolverinterface #232

Closed ds-arithnea closed 4 years ago

ds-arithnea commented 4 years ago

EmbeddedRegexpReferenceResolverTrait.php

Has a wrong method signature:

abstract protected function getReferenceValue($stringIdentifier);

should be:

abstract public function getReferenceValue($stringIdentifier);

eZ\Bundle\EzPublishCoreBundle\Composer\ScriptHandler::clearCache PHP Fatal error: Access level to Kaliop\eZMigrationBundle\Core\ReferenceResolver\EmbeddedRegexpReferenceResolverTrait::getReferenceValue() must be public (as in class Kaliop\eZMigrationBundle\Core\ReferenceResolver\PrefixBasedResolver) in [...]/vendor/kaliop/ezmigrationbundle/Core/ReferenceResolver/AbstractResolver.php on line 89

ds-arithnea commented 4 years ago

Any Feedback on this?

gggeek commented 4 years ago

Sorry, I have been quite busy lately. I hope to have time to give some love to this bundle starting next week...

gggeek commented 4 years ago

Fixed in version 5.10.2