kamildanak / EnderPay

Minecraft mod that adds economy to forge servers.
https://minecraft.curseforge.com/projects/enderpay
GNU General Public License v2.0
7 stars 10 forks source link

[1.12.2] Add support for non-player accounts for mod compat #23

Open Caltinor opened 4 years ago

Caltinor commented 4 years ago

I am building compatibilities for my mod to allow for alternative money mods. During the implementation of Grand Economy I discovered that EnderPay does a player check as part of the packet sent in Account.#setBalance https://github.com/kamildanak/EnderPay/blob/ee888466917cfd60f63160240f08fe5ba0009952/src/main/java/com/kamildanak/minecraft/enderpay/economy/PlayerHelper.java#L14 My mod has accounts for "Guilds" which are non-player organizations and any attempts to modify those accounts when EP is in use throws a RuntimeException. latest.log

Given that I am implementing Grand Economy now and players may request in the future that I support EP directly. I would like to know if it would be possible for EP to implement non-player accounts.