search

kandashi / Active-Auras

MIT License
29 stars 36 forks source link

[BUG] When token is updated that exists on a different scene, module throws error #307

Closed Haxxer closed 10 months ago

Haxxer commented 10 months ago

Describe the bug When a token is updated that exists on a scene that is not currently active, the module throws an error on AAHooks.mjs on line 73.

https://github.com/kandashi/Active-Auras/blob/main/src/lib/AAHooks.mjs#L73

This is most likely because you are trying to access object which is not a valid property on scene that are not active

To Reproduce Steps to reproduce the behavior:

  1. Update a token on a scene that is not active with an active aura on it
  2. See error in console

Expected behavior No error

Screenshots If applicable, add screenshots to help explain your problem.

Environment:

MrPrimate commented 10 months ago

Please can you screen shot the error, and confirm your version, as 0.9.0 fixed this exact issue

MrPrimate commented 10 months ago

Can you also explain how you are updating the token on the non active scene, so i can replicate.

Haxxer commented 10 months ago

Ah, if it was fixed, I might have gotten a faulty report. Let me test with latest, and close this if it is no longer reproductible.

Haxxer commented 10 months ago

Can confirm that it is in fact, fixed. Thanks for checking me!