search

kandashi / Active-Token-Lighting

MIT License
23 stars 25 forks source link

Use filterObject to only set properties that could have been changed by ATL Effects #109

Closed strongpauly closed 1 year ago

strongpauly commented 2 years ago

Fixes #107 in a slightly different way, and could go some way to fixing #100

strongpauly commented 2 years ago

This might be a bit overkill as it may break functionality if people are using ATL to set properties that fall outside of lighting, vision or sizing.

I could see this PR potentially being refactored to filter the properties that can be altered based on module settings.

Feedback appreciated.

ashmedai711 commented 1 year ago

This also appears to fix #120.

szefo09 commented 1 year ago

I would propose adding sight: true, flags: true to allow modificiation of the V10 sight and token specific flags.

kaelad02 commented 1 year ago

Closing it since the issue it's tied to, #107, was closed by the changes #133