kandashi / Active-Token-Lighting

MIT License
24 stars 24 forks source link

Update depreciated fields for V10 #111

Closed Arnold-Muralt closed 1 year ago

Arnold-Muralt commented 2 years ago

When Installing on V10.283, Errors occur on installation, Metadata Validation failed for module ATL, file "/styles/ATL.css" included by ATL does not exist

ATL contains the depreciated "entity" field which must be migrated to "type" ATL uses "author" which is being depreciated in favor of "authors" ATL is using the old flat core compatibility fields, which are being depreciated in favor of "compatibility" object

bearsy1 commented 2 years ago

+1 This module has become essential for my games and I would really like to be able to use it with the added benefits of v10 foundry.

kandashi commented 2 years ago

None of my modules are yet updated for v10. Do not expect quick updates as I have very little time on my hands right now

OsiJr commented 2 years ago

@kandashi, would you accept PRs for v10 updates?

LanMan04 commented 2 years ago

+1 same issue here on Foundry V10.284

LinirZamir commented 2 years ago

I believe we have a PR ready for V10. Is it possible to merge it with main? Is there any other thing that we need to wait on?

CaosFR commented 2 years ago

@kandashi Hi, any news, tests, or a timeline for the update ?

linxcat commented 1 year ago

If we are to go by the same "waiting on PR acceptance" problem also experienced in this other @kandashi module, a fork may be appropriate for the time being or permanently: https://github.com/kandashi/midi-srd/issues/25#issuecomment-1309719026

kaelad02 commented 1 year ago

fixed in #113 and v0.5.0 supports Foundry v10