search

kandashi / Active-Token-Lighting

MIT License
23 stars 25 forks source link

v10 compatibility #113

Closed kaelad02 closed 1 year ago

kaelad02 commented 2 years ago

Update to be compatible with v10

kaelad02 commented 2 years ago

The only thing left I can think of is to update the dialog in GeneratePreset to include the changes. I suspect that's not frequently used so you could update that later. I'll see if I can get it done later today and include it here

etriebe commented 1 year ago

What's the status of this? Have we heard from @kandashi if they'll be able to review?

kaelad02 commented 1 year ago

I just saw a post in his Discord server that he's got some time to look at v10 updates, so hopefully "soon."

kaelad02 commented 1 year ago

@kandashi I worked on the preset editor code and got it working. I replaced the dialog in GeneratePreset with a FormApplication that looks like a trimmed-down version of the token settings app. Here's a screenshot of what it looks like.

image

Are you okay with me pushing this to include as part of this PR or would you prefer I make a new one so you can review it separately?

kandashi commented 1 year ago

@kandashi I worked on the preset editor code and got it working. I replaced the dialog in GeneratePreset with a FormApplication that looks like a trimmed-down version of the token settings app. Here's a screenshot of what it looks like.

image

Are you okay with me pushing this to include as part of this PR or would you prefer I make a new one so you can review it separately?

Hey, if you could include that it would be amazing. If you pull that accross I can merge and get a release sorted

kaelad02 commented 1 year ago

Done, pushed the changes up. I realized last minute I needed to update the GitHub Action to include templates/ in the zip file.

kaelad02 commented 1 year ago

Fixed a bug when setting ATL.sight.visionMode. If you set it to darkvision, for example, you'd still see the map in color. It turns out that the token configuration app also updates some of the advanced vision options that are necessary for the visionMode change to work. It's unfortunate that TokenDocument doesn't take care of this automatically. They did provide a function, TokenDocument#updateVisionMode that will do it but I didn't use it since it triggers it's own update on the token document. That didn't seem like the best use here, so I just copied it's behavior, pulling those default values and setting them, kind of like what preset does.

kaelad02 commented 1 year ago

Something else... DAE has special support for this module's keys. While a module can supply an array of keys on its own, you don't get default values or drop-downs for things like ATL.preset does. We could take it over, but having the drop-down for preset seems nice. After merging this PR, we should get DAE updated with the key changes that v10 made.

CaosFR commented 1 year ago

@kandashi Hi, any news for the merge ?

LanMan04 commented 1 year ago

@kandashi : You work is greatly appreciated, any update on the merge would be fantastic.

LanMan04 commented 1 year ago

FYI! From MrPrimate:

Finally, there is a temporary collection of fixes, primarily by @Kaelad, for Active-Auras and Active Token Effects for v10. These modules are beloved by those of us using a lot of automation, but Kandashi, the author, cannot update them right now due to RL pressures. If you want to use these in your v10 environment, the links are:

MrPrimate commented 1 year ago

Latest commits at https://github.com/MrPrimate/Active-Token-Lighting/releases/download/v0.4.03/module.json

rinnocenti commented 1 year ago

Latest commits at https://github.com/MrPrimate/Active-Token-Lighting/releases/download/v0.4.03/module.json @MrPrimate I don't know if you are keeping this module but there is a very annoying bug happening in these versions. image

if the token has an image from a wildcard (eg images/dragons/*)

when apply some light effect it loses the token texture and returns with the default mystery man texture image

LukasPrism commented 1 year ago

This is probably related to other issues which AFAIK are unresolved, due to ATL reverting to the prototype rather than the token as it was prior to the effect being applied