search

kandashi / Active-Token-Lighting

MIT License
24 stars 24 forks source link

ATL presets change token size, ATL dimensions set to width: blank, height: blank #125

Closed TogaParty closed 1 year ago

TogaParty commented 1 year ago

Describe the bug ATL presets change token size when applied. When affected by an ATL preset, the token is forced to a given size if it isn't already (in my case medium, 5x5).

To Reproduce Steps to reproduce the behavior:

  1. Setup an ATL preset. Leave Dimensions blank.
  2. Apply preset to a Gargantuan NPC

Expected behavior Token size should not change with a lighting effect.

Screenshots If applicable, add screenshots to help explain your problem.

Environment:

Additional context Add any other context about the problem here.

TogaParty commented 1 year ago

Also note that ratio is set to 1.

kaelad02 commented 1 year ago

I noticed this too when working on some other issues. The presets that the module creates for you (e.g. torch) only contain settings to change the light properties so it won't touch things like height, width or scale. If, however, you create a new preset from scratch or a copy, then it'll be saved with all the settings and not just the ones you changed.

I would like to change the preset editor to make it so if you don't set something like scale then it won't be saved as part of the preset. I'm hoping it's possible to do without having to add checkboxes next to everything to indicate you want to change it.