search

kandashi / Active-Token-Lighting

MIT License
23 stars 25 forks source link

support for WFRP4e system "worn/equipped" trappings flag #128

Closed silentmark closed 1 year ago

silentmark commented 1 year ago

Hi,

this PR adds similar support for WFRP4e system that D&D5e already has. It allows to apply effects only when specific item is worn/equipped i.e. torch, lantern or other magic ring.

kaelad02 commented 1 year ago

@silentmark Can you address the review feedback I gave here? https://github.com/kandashi/Active-Token-Lighting/pull/128#discussion_r1161390340 Having a getEffects function will make sure it works for WFRP4e as well as other systems. Plus, for v11 compatibility, I'll need a function like that anyways b/c of some changes in Foundry itself.

silentmark commented 1 year ago

I will take a look into that end of this week

kaelad02 commented 1 year ago

I'm going to make the changes I requested myself. I'll merge this into another branch, so your commits will still be there. Just gonna create another branch to put these in and then another PR to merge into main.

kaelad02 commented 1 year ago

May not need to. I see "maintainers are allowed to edit this PR" so I should be able to commit myself

kaelad02 commented 1 year ago

I didn't realize I could commit to the PR. If I realized that earlier, I would have done this a lot sooner. I think I made all the changes I wanted. Does it look okay to you?