Macro Commands from Docs do not seem to work

[revilowaldow]

Describe the bug Running the commands ATL.GeneratePreset() & ATL.UpdatePresets() which are shown in the module readme file do not work.

To Reproduce Steps to reproduce the behavior:

1. Open Console
2. Run Command
3. 

Expected behavior The present dialog is opened.

Screenshots

Environment:

• OS: Windows
• Browser: Chrome
• Foundry Version v10.291
• Module Version 0.6.2
• All Modules Disabled: No
• Module List if no: Various

[kaelad02]

I went back through the code's history and those four functions haven't been exposed like that since v0.2.17, which is almost 2 years ago now. More recently, I changed how the preset control was implemented and UpdatePresets is the only function I didn't move. It wouldn't be impossible for me to expose an API for these, but I'd have to move some code around to make that happen.

Do you actually need these functions for a macro you're working on or were you just pointing out a possible bug or error with the readme? If you don't actually need them, then I can certainly fix the readme to remove the mention of those functions.

[revilowaldow]

What I was hoping is that I'd be able to use them as a non-GM to setup my own presets. I'm definitely the technical person in our player group and there doesn't seem to be a setting for the GM to allow preset creation/modification for players which he would otherwise grant me. The normal way of doing this (the button) is not available to players.

I guess my root request is, "let players access the preset config" but this was an issue I found while trying to figure out how I might do that.

[kaelad02]

The presets are world settings, not client settings, which is why the control only shows up for GMs (only GMs can change world settings). While technically possible, using sockets as a workaround to let non-GMs make changes to presets, it's a good amount of work for very little gain. I know it's a feature you'd want, but my suspicion is that feature wouldn't get much use. The preset UI itself could use some love and that alone barely gets any feedback.

[revilowaldow]

I can ultimately work around it for my personal use but when another player asks hey can you help me setup these goggles of darkvision things you have I have to coach them through 8 lines of effects. Maybe a tiered preset level where players can create and edit player level presets and the GM can elevate them to world level so all players could use one? The preset UI could do with additional detection mode support for v10 and above but that's a separate request as well.