kandashi / Active-Token-Lighting

MIT License
24 stars 24 forks source link

Light Color Seems to be having issues #148

Closed justinthejaguar closed 1 year ago

justinthejaguar commented 1 year ago

Describe the bug When I enter ATL.light.color I am getting an error with my entries. Tried different cases just in case it was case sensitive.

To Reproduce Steps to reproduce the behavior:

  1. Add ATL Light Color to an on equip item
  2. Equip Item
  3. See error

Expected behavior There should be coloration.

Screenshots Screenshot 2023-09-13 at 11 07 17 PM

Environment:

justinthejaguar commented 1 year ago

Attempted strings:

00FFFF

00ffff

ffffff

kaelad02 commented 1 year ago

What change mode are you using in the active effect?

I tried an active effect like this and it worked as expected: image

kaelad02 commented 1 year ago

Hmm, I tried it with a couple other change modes and still didn't reproduce. To verify, what game system are you using (e.g. dnd5e)?

justinthejaguar commented 1 year ago

I used add. I bet that was the issue. I will do override in the morning.

kaelad02 commented 1 year ago

I can reproduce it using Add. I see the same error. Switching it to override will do the trick.

dineshm72 commented 1 year ago

I am having the same problem as above. Using ATL.light.color on an item I am triggering does not include the color.

image

I also note that there doesn't seem to be an option for color intensity listed. Is alpha the option that maps to color intensity? I don't see any place where you can set an "alpha" for light on the token options. In any case, setting ATL.light.alpha also does not seem to do anything that I can tell.

dineshm72 commented 1 year ago

I think I figured out my issue. The effect was being toggled off/on (passive/inactive) rather than destroyed and recreated, so none of my later edits to add the color were getting incorporated.

dineshm72 commented 1 year ago

Can also confirm that light.alpha = light intensity setting.

kaelad02 commented 1 year ago

I updated the descriptions for some of the keys on the wiki. Mainly putting the label you see in the token config there (e.g. ATL.light.alpha => "Light Color Intensity")

kaelad02 commented 1 year ago

Closing since the original issue was fixed by using Override instead of Add for the color.