search

kandashi / Active-Token-Lighting

MIT License
23 stars 25 forks source link

effects not being applied/applied when equipping/unequipping in wfrp #149

Closed StevenEvans1966 closed 9 months ago

StevenEvans1966 commented 9 months ago

To Reproduce add a wearable item with ATL.preset CUSTOM lantern effect. equip/unequip

Expected behavior equipping the item should change the token lighting to the lantern preset. unequipping should remove lantern settings

kaelad02 commented 9 months ago

Compatibility with WFRP4e was added to this module in version 0.7.0. Can you list the version of Foundry, WFRP4e, and ATE you are using? I just want to rule that out first.

StevenEvans1966 commented 9 months ago

Foundary 11.315 WFRP4e: 7.03 ATE: 0.7.0

Sent from Mail for Windows

From: Chris Seieroe Sent: 05 December 2023 20:03 To: kandashi/Active-Token-Lighting Cc: StevenEvans1966; Author Subject: Re: [kandashi/Active-Token-Lighting] effects not beingapplied/applied when equipping/unequipping in wfrp (Issue #149)

Compatibility with WFRP4e was added to this module in version 0.7.0. Can you list the version of Foundry, WFRP4e, and ATE you are using? I just want to rule that out first. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

kaelad02 commented 9 months ago

I tested it out and initially and I could reproduce it. I created some new armor and added the effect on it to use the lantern preset. I dragged it onto an actor and the token changes happened immediately, whether the armor was worn or not. Then I remembered that game system has it's own tab in the effects with extra options. I edited it to change the Effect Application from "Actor" to "When Item equipped" and then it worked as expected. When I dragged that version onto a PC, nothing happened until I marked it worn.

image

Does it work as expected for you with that setting? If not, I'll keep poking around, but I suspect that's what the problem was.

StevenEvans1966 commented 9 months ago

I tried this with three “worn” item types weapon, armour and tapping [Clothing and Accessories] it only works with armour. I would suggest a lantern should be a weapon as it is held in the hand.

Sent from Mail for Windows

From: Chris Seieroe Sent: 06 December 2023 07:44 To: kandashi/Active-Token-Lighting Cc: StevenEvans1966; Author Subject: Re: [kandashi/Active-Token-Lighting] effects not beingapplied/applied when equipping/unequipping in wfrp (Issue #149)

I tested it out and initially and I could reproduce it. I created some new armor and added the effect on it to use the lantern preset. I dragged it onto an actor and the token changes happened immediately, whether the armor was worn or not. Then I remembered that game system has it's own tab in the effects with extra options. I edited it to change the Effect Application from "Actor" to "When Item equipped" and then it worked as expected. When I dragged that version onto a PC, nothing happened until I marked it worn. image.png (view on web) Does it work as expected for you with that setting? If not, I'll keep poking around, but I suspect that's what the problem was. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

kaelad02 commented 9 months ago

I don't know the WFRP4e system all that well, but we're out of ATE territory now. Now we're into how active effects work in that system, no longer an ATE issue. Creating a miscellaneous item on the character sheet used the Trapping item type. I suppose you could use that, but it doesn't have a Worn toggle like armor does. Instead, you'd need to go to the Effects tab on the character sheet and toggle it that way.