search

kandashi / Active-Token-Lighting

MIT License
24 stars 25 forks source link

Light angle is returning errors when attempting to apply with active effects #32

Closed LuxuriaU closed 3 years ago

LuxuriaU commented 3 years ago

When trying to apply a light emission angle via this module on DAE (without Midi as I know it is currently broken as per the READ ME) it returns an error, informing me that light emission angle must be between 1 and 360 degrees. The attempted value is 60, but I also tried 180 and 360. The same errors were returned.

This likely will not help, but the console's error, it seemed rather generic but here it is just in case: Uncaught (in promise) Error: Light emission angle must be between 1 and 360 degrees. at Token._validateField (opt/foundryvtt/dist/database/odm/abstract.js:1) at Token.validate (opt/foundryvtt/dist/database/odm/abstract.js:1) at Function._onUpdate (opt/foundryvtt/dist/database/odm/embedded.js:1) at async Socket.handleEvent (opt/foundryvtt/dist/sockets.js:1)

kandashi commented 3 years ago

Can you show the details of the effect you were trying to apply

LuxuriaU commented 3 years ago

Can you show the details of the effect you were trying to apply

Screenshot (607) Yeah, sorry, here you go. I have tried various things, making fresh items, doing it on different items, but nonetheless, the error appears.

kandashi commented 3 years ago

I cant seem to replicate this, is there a chance I can join your server to check

Tupsi commented 3 years ago

this does not work neither here. But if I put the light angle into a new (own) preset it works just fine bullseye_preset

kandashi commented 3 years ago

Can you send me the actor/item you are using for these tests also just a point, you need to use UK/US . instead of , for seperating decimals

Tupsi commented 3 years ago

Can you send me the actor/item you are using for these tests fvtt-Actor-Whitford_Lowmane (4).zip also just a point, you need to use UK/US . instead of , for seperating decimals no, that seems to be a localisation thing. Even if I enter 0.4 and hit save, it shows up as 0,4 the next time I open it up. (Windows here is set to German locals). So both seems to work here.

kandashi commented 3 years ago

no, that seems to be a localisation thing. Even if I enter 0.4 and hit save, it shows up as 0,4 the next time I open it up. (Windows here is set to German locals). So both seems to work here. Oh interesting

kandashi commented 3 years ago

You should be using override not add for lightAngle properties. Ive realized this is incorrect in the compendium item too, I'll fix that

I cannot replicate this on 0.2.08 with only ATL enabled