Token vision resetting to 0

kandashi / Active-Token-Lighting

MIT License

24 stars 24 forks source link

Token vision resetting to 0 #43

Closed amcvfx closed 3 years ago

amcvfx commented 3 years ago

I'm having an issue with Token vision settings on linked tokens resetting to zero while using ATL, CUB and MidiQOL. When a character has an effect applied that uses an ATL flag for dimSight (like Eyes of the Night for the Twilight cleric, or Googles of Night) any other effects that are applied or removed from that character seem to reset the dimSight to zero. The issue occurs when these modules are active:

Active Token Lighting
Combat Utility Belt
Libsettings
MidiQOL
Dynamic Effects use Active Effects

kandashi commented 3 years ago

Does the Prototype Token settings of the actor have a dimSight of 0 ?

amcvfx commented 3 years ago

Yes those are characters with dimSight 0 by default

kandashi commented 3 years ago

Oh you mean non ATL effects cause a reset to 0 ?

amcvfx commented 3 years ago

Yes non ATL effects. Any effect that is toggled on the character resets the dimSight to 0.

kandashi commented 3 years ago

I can only replicate this when deleteing an active effect, not toggle or creation, can you confirm this?

amcvfx commented 3 years ago

I tried it again and it does still seem to happen when applying and removing other active effects

kandashi commented 3 years ago

what other modules that interact with active effects do you have enabled?

amcvfx commented 3 years ago

These are all the modules active (I tested them with Find the Culprit):

Active Token Lighting Combat Utility Belt Libwrapper MidiQOL Dynamic Effects use Active Effects

RavenknightDM commented 3 years ago

We've noticed the same issue. Removing a (none-ATL) effect from a linked token will remove the light on the character. Non-linked characters are fine.

kandashi commented 3 years ago

This should be fixed in https://github.com/kandashi/Active-Token-Lighting/tree/0.2.12, if anyone can test to confirm that its fixed that would be great.

RavenknightDM commented 3 years ago

This should be fixed in https://github.com/kandashi/Active-Token-Lighting/tree/0.2.12, if anyone can test to confirm that its fixed that would be great.

Will test it once I get back from work. Thanks Kandashi.

RavenknightDM commented 3 years ago

Hiya, Kandashi. I've installed the 0.2.12 version but I still get the same error.