kapsiR / HaveIBeenPwnedKeePassPlugin

KeePass plugin which integrates the k-Anonymity pwned password search from HIBP
MIT License
44 stars 1 forks source link

`Check current password` functionality improvement request #7

Closed yuriw closed 4 years ago

yuriw commented 4 years ago

When I do Check all passwords I get:

image

But when I do Check current password I actually see nothing? Ref: https://github.com/kapsiR/HaveIBeenPwnedKeePassPlugin/issues/6#issuecomment-619609467

I think Check current password should behave like https://haveibeenpwned.com/Passwords For example, if a user wants to verify password 12345, the website comes back with message: image

I suspect that novice users won't even know what the plugin does without such functionality.

kapsiR commented 4 years ago

Just to clarify, when you check a single entry, you only get a message, if the entry has been pwned. From the readme Check the current selected entry: check single entry

So is your intention that you always get a message, even if the password is ok?

yuriw commented 4 years ago

@kapsiR Yes I think when a single entry id checked in any case a message should be shown

kapsiR commented 4 years ago

Thanks for clarification. I'll consider it for the next release 😉

kapsiR commented 4 years ago

@yuriw You can try it out directly with the current v0.6.0-preview version 😉

yuriw commented 4 years ago

@kapsiR works great thx for quick implementation!