kapsiR / HaveIBeenPwnedKeePassPlugin

KeePass plugin which integrates the k-Anonymity pwned password search from HIBP
MIT License
44 stars 1 forks source link

Ignore entry #8

Closed LarsBodewig closed 4 years ago

LarsBodewig commented 4 years ago

Hi, it would be nice to tag an entry or something to exclude it from checking. The condition could be extended similiar to ignoring expired entries. 1.

private const string IgnoreTag = "ignore-pwned";

2.

if (!pwEntry.Tags.Contains(IgnoreTag)) {
    // ...
}

3.

entries = entries.Where(entry => !entry.contains(IgnoreTag));
kapsiR commented 4 years ago

Will consider this for the next release, but can you clarifiy your use case please?

LarsBodewig commented 4 years ago

Sure: I do have entries that are unavoidably pwned like a 4-digit pin code. These "passwords" do not qualify for a HIBP check as they are meant to be generic. With a few lines of code it would be possible to mark these entries for exclusion so they are not reported as breached.

kapsiR commented 4 years ago

So you don't even want to know whether these entries are pwned or in other words, they shouldn't be in the numbers?

Do you want to tag them already in the first place or after the first time they got reported? (With a new tag, we've both options of course)

I'm just thinking about a more generic approach with no need for manual actions but I'm afraid there is none...

LarsBodewig commented 4 years ago

Yes. I don't think this is possible without manual actions. That's why I thought of a tag to add by hand.

kapsiR commented 4 years ago

@fan2404 I have just released a new preview version that you can use right now 😉

LarsBodewig commented 4 years ago

Awesome, the toggle menu item makes it even more comfortable to use. gj