[Tropical Biome]Plants to add

kaptain-kavern commented 8 years ago

Plants
Fern 1,2,3	tall grass stats	Slow movement	Must be edible by herbivores
Palm01	tall grass stats	slow movement (like tall grass)	Must be edible by herbivores
Palm02	minyield: 4/ max: 22/ growth time: 12	HP: 120/ beauty: 1	__
Palm03	minyield: 6/ max: 32/ growth time: 18	HP: 210/ beauty: 1	__
Strangler Fig	minyield: 10/ max: 18/ growth time: 10	HP: 300/ beauty: 2
Mahogany Tree	minyield: 22/ max: 56/ growth time: 34	HP: 320/ beauty: 2
Rafflesia	bush stats	-15 beauty	__

[x] ~~Fern (3 variations)~~
[x] ~~Palm (3 variations)~~
[x] ~~Mahogany Tree~~
[x] ~~Strangler Fig~~
[x] Rafflesia

Spreadsheet with all plants Data extracted from game files (for balancing values)

lpCoercion commented 7 years ago

Heliconia

lpCoercion commented 7 years ago

Taro Root tarofood

Coffee Beans coffeebeans

Coconuts

Bananas bananas

lpCoercion commented 7 years ago

That should be all of the plants. Let me know when they all make it in game :)

kaptain-kavern commented 7 years ago

omg neat !

I just wake up here. Let me have my coffee ( coffeebeans ) and it will be quick :stuck_out_tongue:

Bamboo and Lemongrass are already in btw :wink:

lpCoercion commented 7 years ago

The rainforest looks great btw :)

I posted a screenshot to the forums.

to do list:

make the plants (ferns) slow down pawns considerably more. [done]
make trees take a lot longer to cut down, but provide a lot more wood. [done]
make rafflesia less common? [done]
make the predators hit harder, so that only a few hits can take out a pawn. [done]
remove the pathcost from the banana tree and make it an occupied square [done]
make the other plants take longer to cut down/clear. [done]
make the plants/trees provide a lot more cover. [done]
Is it considered dark when raining? If not, make it be considered dark for solar panels.

kaptain-kavern commented 7 years ago

Ok buddy, all new graphics are in :+1:

I have some IRL matter to attend to and I came back to reply to your question. (all of it is doable except maybe rain/light relation)

Do you want me to explain where it is done in the code (for you to know it) or just that I do it?

lpCoercion commented 7 years ago

awesome :)

no worries. real life comes first.

I will take a look at the code in a bit. I may be able to make the changes myself. If not, I will let you know. I will work on testing today. If everything looks good, I will post v1.0 tonight :)

kaptain-kavern commented 7 years ago

to do list:

Make the plants (ferns) slow down pawns considerably more.

The value is defined with the \ tag : can look here https://github.com/kaptain-kavern/CK_AnimalPlant_Pack/commit/c71c6994d20f91fbc628221566bec211dccb3f7c

Make trees take a lot longer to cut down, but provide a lot more wood.

The value is defined with the \ tag : can look here https://github.com/kaptain-kavern/CK_AnimalPlant_Pack/commit/e4ab6049116408e242ce583023bf2c846fa249ca

Make the other plants take longer to cut down/clear.

Same as above

~~Make rafflesia less common?~~ [done]

You already figured out this one.

Make the plants/trees provide a lot more cover.

The value is defined with the \ tag : It's defined at 0.43 (exactly like in Vanilla) in our _/Defs/ThingDefs_Plants/PlantsBases.xml file (If you change it in this file, then all of our trees will inherit this value; else you can add the tag in each trees code - _in the PlantsTropical.xml file - for individual different values.

Make the predators hit harder, so that only a few hits can take out a pawn.

For now all I've done is copy/paste Vanilla values, so our felines are hitting exactly as hard as cougars/panthers in vanilla. (just for you to know, regarding on how you want to balance them with vanilla animals).
The value are defined in each animal code. It is starting from tags in the code. Each "paragraph"(starting by a <li> and closed by a <\li>) define one attack (like for felines : two "paragraphs", one for each front paws, and one other for a bite attack). And there you can change values. Note that it works like I explained above for plants and plantbases; if you change values for the bases (I always put them first on top of the files) all animals using that base will inherit those values; else you can define them for each animals (lower in the file) in their respective code part

Is it considered dark when raining? If not, make it be considered dark for solar panels.

For this one i'll have to investigate a bit, but i'm pretty sure i've seen reference to that in the code. I'm not sure where :laughing: ... Maybe in biomes, or weather files ... I will search

kaptain-kavern commented 7 years ago

can you also remove the pathcost from the banana tree and make it an occupied square?

In the code it set to <passability>PassThroughOnly</passability> so I was thinking it would count as occupied square? (But haven't particularly tested this)
Does the Banana tree not behave like other trees?

It does. I was confused because it has a pathcost

lpCoercion commented 7 years ago

I made all of the changes except for the solar panels in rain. I was told by someone on slack that rain already effects solar panels.

Also, I dont see any heliconia in game.

kaptain-kavern commented 7 years ago

Damn, too bad I don't have enough time to hang out on the Slack as before ... :cry:

It's weird, because I see some : Imgur

Ho ! But there are not selectable (like grass and our Ferns and Bromeliad) want me to change that ? We could even make them plantable in pot! (I imagine potted Rafflesias for putting in prisoner rooms ^^)

lpCoercion commented 7 years ago

no its fine if they are there. I may have just not been able to find them. I will look again :)

lpCoercion commented 7 years ago

If you have time today do some testing. If everything is working good, I will post up v1 tonight. :)

kaptain-kavern commented 7 years ago

I'm doing it right now.

There is little things to polish (like Coffee and LemonGrass are just blend simple ingredient, it may be nice to complexify things a bit, like having a coffee to drink - coded like a drug like chocolate in Vanilla) but for the rest it will really be by playing that we may noticed things or have bug reports/suggestions from users. That for saying, to me it's like we can do the 1.0 release :tongue:

lpCoercion commented 7 years ago

I think we need to push out a quick patch (v1.0.2) to fix banana yield. Can you change the banana yield from 30 to around 8 or 12? Does this change seem resonable?

kaptain-kavern commented 7 years ago

I'm OK. Let's start with 12 and see how it goes :wink:

Edit : Done :+1:

kaptain-kavern commented 7 years ago

Could you please look at #16 ? I have a little change in the code in mind but I want your opinion before doing anything

lpCoercion commented 7 years ago

awesome thanks.

i responded. i agree that the taro are way too overpopulated and ferns shoukd be more prevelant. I dont know the fix though.

lpCoercion commented 7 years ago

Plants to add: cocoa tree (plant) cocoa beans (ingredient) chile pepper (plant) [3 variations] red chile green chile yellow chile vanilla (plant) vanilla beans (ingredient) tobacco (plant) tobacco (ingredient)

kaptain-kavern commented 7 years ago

Ok doke. So I guess i'm waiting for more textures :p

On an other note : I noticed our flowers have very low beauty value compared to vanilla potted ones : Bromeliad: 3 and Heliconia: 5 for Daylily: 24 and Rose: 14 ; but are in par with the wild ones Astragalus and Dandelions.

This brings me to the point : I find it could be nice to been able to put Tropical flowers in pots to embellish bases, what you think?

lpCoercion commented 7 years ago

i like the idea. can you get a screenshot? I am not sure if they will look good potted.

kaptain-kavern commented 7 years ago

2 ways I see for this :

Either we stick to Vanilla and let our wild tropical plants with their actual beauty value AND i make a copy for the potted version with beauty up to 24 like vanilla potted plants.
Or we bump the beauty up to 24 like in Vanilla even for the wild ones and I just add the tag make them appear with pots

lpCoercion commented 7 years ago

maybe we should try 25 for heliconia and 15 for bromeliad even for the wild ones. and just add the tag to make them appear in pots. thoughts?

kaptain-kavern commented 7 years ago

Ok for me. It's the simplest solution regarding code ^^

lpCoercion commented 7 years ago

If the flowers look weird potted though, I may have to create a new texture for potted versions anyway though lol

kaptain-kavern commented 7 years ago

First Try Imgur

kaptain-kavern commented 7 years ago

Better now Imgur

It's in dev ==> Commit : https://github.com/kaptain-kavern/CK_AnimalPlant_Pack/commit/4eea60fd4526cb4ea08871c6540de0cf4e572c6e

lpCoercion commented 7 years ago

looks pretty good. I will fix the texture tonight (to center them in the pot). It may be easier to just copy and paste the defs so we can make changes to the wild and potted separately.

maybe we should add more :P potted ferns?

kaptain-kavern commented 7 years ago

That's how I've done in the end, separate defs. Because they should behave differently than the wilds one.

The plant that have 25 of beauty will have to be replanted twice more often than the one with 15

He no problem for adding more :-p

lpCoercion commented 7 years ago

could make the ferns 10 beauty and need to be replanted even less?

Also, thinking about this more, I think we should leave the wild flowers at their vanilla equivalent beauty

kaptain-kavern commented 7 years ago

Done.

Added potted ferns and changes wild bromeliads and Heliconias beauty to 6 and 7(still a bit more than Vanilla, because hey it's beautiful tropical flowers ;) )

lpCoercion commented 7 years ago

awesome. any potted fern screenshots?

SpaceDorf is worried about plant beauty. have you expierenced this too? If so, would raising ferns to beauty 1 solve the problem?

kaptain-kavern commented 7 years ago

Beauty set to 1 for Palm, Fern, Taro and Lemongrass on Dev.

Imgur

lpCoercion commented 7 years ago

very cool. do you think that the fern should be slightly bigger? does the pot use all three variations of ferns?

kaptain-kavern commented 7 years ago

In fact, we can play a bit with size in the code with <visualSizeRange> and for all potted versions of plant I had to set them to the same value (something I noticed in Vanilla code) for it looking better. I can try to increase ferns a bit.

Also as you can see on the first screenshot (above) , like vanilla flowers, I set them to been able to be planted in pot AND soil; except for ferns, I can't explain exactly why but that seemed weird to cultivate ferns in the forest ^^ - it can be changed too though

And yes the pot use all textures version. If I understand how things work correctly, the <graphicClass>Graphic_Random</graphicClass> tag in the code means : Use randomly anything find in the folder path (declared with <texPath> just above in the code) Imgur

lpCoercion commented 7 years ago

These textures should fit the pots better. These are separate textures and do no replace the wild ones:

Potted Bromeliad pottedbromeliad

Potted Heliconia pottedheliconia

kaptain-kavern commented 7 years ago

Ok the potted ones are done. :+1:

Also I've "tried something" just want to know your opinion.

I tried to make the Flowers planted in Crop to use the wild textures, (meaning that as they grow there will be several plants to flourish one the same spot). Just tell me what you think (I can't decide myself)

(You can also see the potted with their new textures) Imgur

Or using the same textures as potted ones : Imgur

lpCoercion commented 7 years ago

That top screenshot is awesome. Good idea :)

Can you make the potted flowers a little bigger?

kaptain-kavern commented 7 years ago

I just upped them a bit, from

      <visualSizeRange>
        <min>0.9</min>
        <max>1.1</max>
      </visualSizeRange>

to

      <visualSizeRange>
        <min>1.2</min>
        <max>1.5</max>
      </visualSizeRange>

lpCoercion commented 7 years ago

alright cool. whatever looks good :)

lpCoercion commented 7 years ago

Can you remove the injestible tag from ferns? That way animals will eat taro and other edibles/harvestables instead.

lpCoercion commented 7 years ago

Or would this remove harvestables completely?

... maybe we make ferns non-injestable, but have shorter lifespans?

kaptain-kavern commented 7 years ago

For know I've done like in Vanilla, meaning all plants that is useful have a lower value than others (moss, grass, etc).

It was more because we haven't discuss it rather than because I wanted it that way.

I fear that completely removing the will break the ecosystem.

What we can try also is change those values. Making fern values lower than other plants. That way I think animals will prioritize fruits-bearing and other "good plant" rather than ferns, but will not die of starvation in a the middle of ferns forest ;)

That way we don't introduce massive changes and I think reach the same goal you were aiming for

lpCoercion commented 7 years ago

alright cool.

lpCoercion commented 7 years ago

would this need to be pushed out in a patch?

kaptain-kavern commented 7 years ago

I haven't done it yet. But it can be include in next release. I also have to make some changes in plants (about blight incident resistance like discussed in the forum thread) so I will include both changes at once.

I also have all the code ready for Bongos, if needed for next release ;)

lpCoercion commented 7 years ago

oh ok cool. bongos should be ready for next release :)

kaptain-kavern commented 7 years ago

Ok I tried the changes discussed above and it's all working. Animals are not completely ignoring ferns but they make "efforts" to search and eat the good plants first. - (This alone wasn't savecompatible)

As changes above will require a new save. I also completely reworks some plants defs location in the different files (even created more files - the ones in bold below) :

Plants_Cultivated_Decorative.xml contain the potted version of plants we add
Plants_Cultivated_Farm.xml contain the crop version of plants we add
Plants_Tropical.xml now only contain the wild version of the modded plants we add
Plants_Vanilla.xml contain the wild version of vanilla cultivated plants
Plants_Bases.xml contain only the basedef all other plants are using

Two reasons :

It was required to have cultivated plant not been able to spawn wild or the blight incident will not target them too (it is coded like that in C# - as Zhentar pointed it, there)
It will help when we will introduce modular packs/mini mods. Also if someone have something he don't like it is easier to erase part of the mod.

The only thing is that all of this is not save-compatible (So it's on a separate branch for now - https://github.com/kaptain-kavern/CK_AnimalPlant_Pack/commit/b0d35fd498257b26791af13f5035d100a1810409). So maybe there is no need to rush the release and wait for adding more. Either way it's OK with me, just something to consider

I have the other ongoing changes (namely Bongo's and the optional changes to elephant for eating trees) on the Dev branch

kaptain-kavern commented 7 years ago

With the next released in mind (new plants, crops, recipes, etc), I went nuts and progressed on several "fronts" yesterday, here is an update because I want to know if it suits you :

https://github.com/kaptain-kavern/CK_AnimalPlant_Pack/commit/baf7f96934b8db5105a281d1aa6ed194b9e7f066 - Cigarettes added (need texture for plants at least, I managed a rolled cigarette textures by recoloring joints)
https://github.com/kaptain-kavern/CK_AnimalPlant_Pack/commit/0e4271d3aae0701be157e14dc581e2446750d4a3 - All soil plants now have higher value (between 0.14 and 0.25) than ferns (set to 0.12) : Animal should prioritize eating "good" plants before ferns
https://github.com/kaptain-kavern/CK_AnimalPlant_Pack/commit/b0d35fd498257b26791af13f5035d100a1810409 - Separate wild plants from potted and croped ones for the blight incident issue

lpCoercion commented 7 years ago

looks good :)

Can you please check out the checklist issue?

https://github.com/kaptain-kavern/CK_AnimalPlant_Pack/issues/2#issuecomment-250930615

kaptain-kavern / CK_AnimalPlant_Pack

[Tropical Biome]Plants to add #6

to do list: