kardiachain / kardia-explorer-backend

Backend repo for explorer

2 stars 7 forks source link

KRC20 token icon in API responses should be a hyperlink instead of a base64 image #109

Closed trinhdn97 closed 3 years ago

trinhdn97 commented 3 years ago

Prerequisites

Current responses of internal transactions, KRC20 token info and holders API return token logo in base64 format. Because average size of a icon is about 100kB, API responses are very heavy. We should upload the token logo to some online hosts and store/return the hyperlink of the logo only.

ngdlong91 commented 3 years ago

@AjackTi : Please provide new API's response

AJackTi commented 3 years ago

Current response: Inserting, Updating the field logo with format base 64 in both table contracts and addresses
New response: Inserting, Updating the field logo with a link saved in the S3 AWS in both table contracts and addresses

Affected API:

Insert contract, address (/api/v1/contracts)
Update contract, address (/api/v1/contracts)