search

kbase / kb_sdk_docs

KBase SDK Documentation
http://kbase.github.io/kb_sdk_docs
MIT License
0 stars 12 forks source link

Update internal links to stay on same tab / add <uid> to HelloWorld module name #22

Closed landml closed 5 years ago

landml commented 5 years ago

@jayrbolton, @bio-boris - As discussed in a previous PR, I am changing the links that stay on the documentation site to open in the same tab instead of a new tab. Along with this, all links are now done consistently with 'External links' and 'Internal links' at the bottom of the page. It is easy to see all the links together and check for consistency and duplication.

In addition there are some changes that should have had their own commit. There was confusion during the SFA SDK training over the module names that were simply called 'HelloWorld' or 'ContigFilter'. Anyone following along could have used these literally and then had problems during registration. I added a to all the references to HelloWorld and ContigFilter module names. Because it historically has been difficult to rename a module, it seemed wise to remind developers that they need to use the unique name they created for their module.

jayrbolton commented 5 years ago

:+1: :+1: After I merge, I will double check everything and deploy these changes.

jayrbolton commented 5 years ago

Just deployed it.