search

kbase / kb_sdk_docs

KBase SDK Documentation
http://kbase.github.io/kb_sdk_docs
MIT License
0 stars 12 forks source link

Jungbluth patch 1 #41

Closed jungbluth closed 5 years ago

jungbluth commented 5 years ago

Many small fixes, etc. Hopefully these suggestions are useful!

PS: Sorry for all the commits, still getting my dev environment up and running (working on temp computer at the moment)

jungbluth commented 5 years ago

All changes made - thanks for your input. Just ran make check and got the following:

source/tutorial/7_implement.rst:68: (ERROR/3) (python) invalid syntax source/tutorial/7_implement.rst:111: (ERROR/3) (python) invalid syntax source/tutorial/7_implement.rst:225: (ERROR/3) (python) invalid syntax source/tutorial/7_implement.rst:322: (ERROR/3) (python) invalid syntax make: *** [check] Error 1

The four python errors are okay (I believe). Not sure about the last one...

jungbluth commented 5 years ago

"Fixed unexpected indent" was the final change (forgot to push)

jayrbolton commented 5 years ago

Bueno... will check & merge soon

jayrbolton commented 5 years ago

We're lookin good. I'm going to squash the commits when i merge

jayrbolton commented 5 years ago

Changes should be live now

jungbluth commented 5 years ago

Nice!