10:9 ratio with filter on gb

kbeckmann / game-and-watch-retro-go

Emulator collection for Nintendo® Game & Watch™

GNU General Public License v2.0

433 stars 130 forks source link

10:9 ratio with filter on gb #161

Closed wzhy90 closed 2 years ago

wzhy90 commented 2 years ago

Hi again. In new version gb emulator add scaling mode and filter, but atm the orginal ratio didnt have filter feature. I try to change resolution in gb_main.c at "screen_blit_bilinear". while I change w2 and dst_img.w to 266 and hpad to 14, the image will move to the center of screen, but it cut out 14x240 pixel at the right of image, how to fix this?

kbeckmann commented 2 years ago

The bilinear scaling code is a bit of a hack, so it didn't handle padding well.

You have motivated me to add a few more scaling options in 017e2c718352912016171c637303f68a42657649

Fit + Soft -> bilinear scaling (this is what you are requesting, right?)
Full + Off -> NN scaling

Please try it out and let me know if it's what you expect.

wzhy90 commented 2 years ago

yeap, that's what I want. BTW, is it possible to add 266x240 resolution to "screen_blit_v3to5" filter?

kbeckmann commented 2 years ago

Yeah it can be done but requires a bit of effort 🙂