kbeckmann / game-and-watch-retro-go

Emulator collection for Nintendo® Game & Watch™
GNU General Public License v2.0
440 stars 133 forks source link

gw_flash: Add support for Winbond W25Q128JWSIQ 16MB Flash #169

Closed unhold closed 2 years ago

unhold commented 2 years ago

W25Q128JWSIQ is widely available in SOIC-8. Some testing done.

unhold commented 2 years ago

It worked flawlessly, I could flash it multiple times without any issue. In fact, it also worked with the default configuration. But the first try after the pull request failed, I have to figure out why.

kbeckmann commented 2 years ago

Thanks. Hope you can find what’s wrong. The pr looks good otherwise and the commands seem to be correct according to the data sheet. Perhaps some init sequence might be needed to reset the chip?

unhold commented 2 years ago

Thank you for checking it! Finally had the inspiration to figure it out: I had protection bits in the status registers set, because I accidentally executed init_mx_issi() on the Winbond. The pull-requested code was fine.