search

kbeckmann / game-and-watch-retro-go

Emulator collection for Nintendo® Game & Watch™
GNU General Public License v2.0
440 stars 133 forks source link

Fix for issue [Clear framebuffer after macro OSD disappears #164] #185

Closed c0de90e7 closed 2 years ago

c0de90e7 commented 2 years ago

This is a fix proposition for issue #164. Basically, in any transition from any overlay to no overlay, we draw a black rounded rectangle of the same size and at the same position as the overlays are drawn. NOTE: we do so in both the active and the inactive frame buffers.

c0de90e7 commented 2 years ago

Also, forgive my lack of experience here. I am new to this kind of work flows. I do use git but I am not very used to public PRs :(

kbeckmann commented 2 years ago

Also, forgive my lack of experience here. I am new to this kind of work flows. I do use git but I am not very used to public PRs :(

No worries, this was all going by the book. And fix commits are expected and perfectly normal.

Thanks again for helping out.