kbwbe / A2plus

Another assembly workbench for FreeCAD, following and extending Hamish's Assembly 2 workbench
GNU Lesser General Public License v2.1
168 stars 69 forks source link

Optimize calcMoveData #622

Closed edwin-bergstedt closed 6 months ago

edwin-bergstedt commented 6 months ago

Optimize calcMoveData by reducing looping. In my test case the speed increased with 12% and the number of calls was reduced by 14%.

Combined with the Caching optimization the speed increase was 14%, and the number of calls was reduced by 19%.

kbwbe commented 6 months ago

Thank you. I have made short tests. Everything seems working.

edwin-bergstedt commented 6 months ago

My plesure, I hope everything will work, but it's difficult to try everything. Thank you, for including it and for all your work.

Den lör 2 mars 2024 14:19kbwbe @.***> skrev:

Thank you. I have made short tests. Everything seems working.

— Reply to this email directly, view it on GitHub https://github.com/kbwbe/A2plus/pull/622#issuecomment-1974795395, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6COVWMR3BHIPH7W4RP54LYWHGVNAVCNFSM6AAAAABEAXET26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZUG44TKMZZGU . You are receiving this because you authored the thread.Message ID: @.***>