main.h is a very misleading name, and alure::Bitfield shouldn't be located in there

kcat / alure

Alure is a utility library for OpenAL, providing a C++ API and managing common tasks that include file loading, caching, and streaming

zlib License

70 stars 20 forks source link

main.h is a very misleading name, and alure::Bitfield shouldn't be located in there #11

Closed Cazadorro closed 10 months ago

Cazadorro commented 6 years ago

Looking for what the heck DECL_THUNK0->3 are, found it was defined in main.h for some reason. For some reason main.h also has alure::Bitfield, definition inside of it. not sure why this is here, but I can make a pull request if I've got the time to fix this, its really confusing looking at the source code and trying to remember "oh bitfields is in ... main.h?"

kcat commented 6 years ago

I suppose main.h would be better named misc.h. Since Bitfield is so small and not something to be made public, I didn't feel it was worth making a whole new header just for it. But maybe I should. Most IDEs should be able to tell you where things are declared or defined, though.