search

kcat / alure

Alure is a utility library for OpenAL, providing a C++ API and managing common tasks that include file loading, caching, and streaming
zlib License
70 stars 20 forks source link

_INCLUDE_DIRS vs _INCLUDE_DIR #3

Closed karamellpelle closed 7 years ago

karamellpelle commented 7 years ago

Inconsistent naming: . /CMakeLists.txt use MPG123_INCLUDE_DIRS but ./cmake/FindMPG123.cmake use MPG123_INCLUDE_DIR. ~XXX_INCLUDE_DIRS (with a S) seems to be the convention, so I assume FindMPG123.cmake should be modified.~ I'm not sure which to use .

My mpg123 is installed (via homebrew) in /usr/local and /usr/local/include is not given to the compiler since ./CMakeLists.txt use the variable with S and this is empty. This gives a compilation error.

kcat commented 7 years ago

Fixed in commit 167737ff43763c9baa6c779e005a58d81bf5f0d9