search

kcmerrill / alfred

(v0.2) Even Batman needs a little help. Task runner. Automator. Build system.
MIT License
64 stars 14 forks source link

Different template engine #83

Open iilyak opened 6 years ago

iilyak commented 6 years ago

Is there any benefit of replacing go templates with https://github.com/flosch/pongo2?

kcmerrill commented 6 years ago

Interesting ... Let me see if it plays nicely with standard go templates too. If it does we can add that in too.

Didn't know that existed but looks fun. I'll give it a go

On Wed, Jul 25, 2018, 8:21 AM iilyak notifications@github.com wrote:

Is there any benefit of replacing go templates with https://github.com/flosch/pongo2?

  • Would it be easier for non go developers?
  • Is it hard to plug in?
  • Is it in a long term vision for alfred to support multiple template engines (or replace current one)?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kcmerrill/alfred/issues/83, or mute the thread https://github.com/notifications/unsubscribe-auth/AAqMSVjhGodv-DLRJBTT3XaKH2uMDbfKks5uKH7lgaJpZM4VgLTs .

kcmerrill commented 6 years ago

pongo2 doesn't play as nice with structs as I'd hope, so because it's not using the same interface to translate it's a bit trickier.

It's an interesting idea. I'd like to continue support for the stdlib go template engine, but would be a nice to have if it can support multiple.

Let me chew on this.