kdgutier / esrnn_torch

MIT License
156 stars 45 forks source link

Monthly M3 Implementation of ESRNN #7

Closed FangSimon closed 4 years ago

FangSimon commented 4 years ago

Hi there,

Thanks a lot for the great implementation. I am trying to fit the monthly M3 data, but the model does not seem to be training. My data looks as follows:

image

image

image

image

Note that the y_hat_naive2 is in fact just the simple naive.

When, I fit the model, I get the following:

image

In an earlier issue, it has been mentioned that it could possibly be a mismatch in forecasting horizon, but after playing around with it, I don't see any improvement. Below, you can find a link to the colab notebook so you can reproduce it.

https://colab.research.google.com/drive/1rFz5SskOqKuaxn3ijZUJwIPBqDGy7AK1?usp=sharing

Thanks a lot!

Simon

chendiva commented 4 years ago

I have the same issue, have you solved it?

FangSimon commented 4 years ago

No I unfortunately, I have not solved it.

AzulGarza commented 4 years ago

Hi!

We reviewed the colab notebook and made a few small changes to resolve the issue. In particular, we believe the following points will be useful for you:

Thanks for your comments!

Reviewed colab notebook