Show more content - Githubissues

keboola / indigo-ui

Indigo UI library, its CSS and React components. Also Styleguide app showing usages of this library.

https://indigo.keboola.com

MIT License

5 stars 0 forks source link

Show more content #237

Closed janmichek closed 5 years ago

janmichek commented 5 years ago

blbost, ty stary styly prozatim vracim

janmichek commented 5 years ago

S tim snapshotem mi to moc nejde, respektive se mi to nedari updatnout prikazem 'yarn jest --updateSnapshot' . Pritom je videt, ze ve 'PanelWithDetails.test.js.snap' jsou stary snapshoty a melo by se neco stat. Nevis cim by to mohlo byt, nez se do toho ponorim?

ujovlado commented 5 years ago

to neviem ci je nejaky "cargo cult" alebo kde sa nabralo, ze sa to ma robit cez yarn jest --updateSnapshot :)

pisal som, ze ich treba doplnit - t.j. aktualne to co tam je, je ok, akurat som chcel aby sa doplnila aj ta nova prop.

doplnim ten snapshot ja, potom kukni co som spravil (resp. napisem ti to sem).

janmichek commented 5 years ago

Dobre, jsem zvedavej jak se to dela xD

ujovlado commented 5 years ago

Je to dost easy :)

Pustis yarn test - spusti sa ti interactive mode a uz len cakas. (BTW, takmer to iste co v kbc-ui - tam sa to vola yarn tdd.)

Potom ako pridas novy test alebo nieco upravis, tak sa to samo spyta, co chces urobit. (v tomto pripade som stlacil u).

screenshot_2018-08-16_15-36-04

ujovlado commented 5 years ago

Tie snapshoty su pri vyvoji komponent/kniznic dost dolezite ... zabezpecuju, ze sa nieco nerozbije a komponenta nezacne generovat zrazu nieco ine.

ujovlado commented 5 years ago

Napriklad sa pomylis a zmenis classname:

diff --git a/src/indigo/components/PanelWithDetails.jsx b/src/indigo/components/PanelWithDetails.jsx
index eac90d6..2057c65 100644
--- a/src/indigo/components/PanelWithDetails.jsx
+++ b/src/indigo/components/PanelWithDetails.jsx
@@ -19,7 +19,7 @@ class PanelWithDetails extends React.Component {
         header={this.state.panelHeaderTitle}
         defaultExpanded={this.props.defaultExpanded}
         className={classNames({
-          'panel-show-details': true,
+          'panel-show-detail': true,
           [`panel-show-details-${this.props.placement}`]: true,
           'panel-preview': !!this.props.preview,
           [`panel-preview-${this.props.preview}`]: !!this.props.preview

Je to typo a v podstate ti "len ujde" s.

Testy na to zareaguju, prestanu sediet snapshoty (markup):

screenshot_2018-08-16_15-46-39

ujovlado commented 5 years ago

Treba to ale robit v klude a premysliet si kedy mozem dat u a kedy nie. V tomto PR to bolo ok (lebo sa len pridal test). Ale keby si to spravil v tomto priklade co pisem, uz by to narobilo bordel.

janmichek commented 5 years ago

dik za vysvetleni, vetsinou jsem si vystacil bez toho interaktivniho rezimu. Ukladam link pro priste.

ujovlado commented 5 years ago

staci si zapamatat yarn test ... to ti moze bezat stale niekde vedla v okne ;)