keboola / indigo-ui

Indigo UI library, its CSS and React components. Also Styleguide app showing usages of this library.
https://indigo.keboola.com
MIT License
5 stars 0 forks source link

NotAvailable component (or styles at least) #249

Closed ujovlado closed 4 years ago

ujovlado commented 5 years ago

This can be really useful in situations when we want to say something is not available.

Context:

It can be solved by separate component or only a class.

Proposal:

screenshot_2018-08-22_16-11-09

ujovlado commented 5 years ago

Asi by stacilo aby to bola zatial len nejake classa, ktoru dam neblokovemu elementu. :)

ujovlado commented 5 years ago

Potom bude treba vyhodit to em z keboola/kbc-ui#1915

janmichek commented 5 years ago

jo - italic stylu se chceme zbavit v ramci 2. vlny upravy fontu https://github.com/keboola/indigo-ui/issues/189

ujovlado commented 5 years ago

Skor som narazal na to, ze to tam teraz pribudlo. Nechame to tak?

janmichek commented 5 years ago

V soucasnym stavu je mi to jedno. Vyskytuje se to na vice mistech.

janmichek commented 5 years ago

Tak jo, poustim se do toho. Nejdiv prozkoumam ruzny empty stavy (je to ruzne rozesety po aplikaci) a potom tady zkusim pripravit vizualni navrh

janmichek commented 5 years ago

Vetsina empty statu se da v kbc vyhledat pomoci retezcu 'N/A', 'No ', 'text-muted', '<em>'

janmichek commented 5 years ago

Analyza a navrhy

1) Takhle jsem nasel ruzny pouziti 'N/A' jako empty stavu:

image

image

image

Tady to bude easy, to navrhuju sjednotit pomoci <NotAvailable/> komponenty v indigo UI aby to vypadalo jednotne takto image


element.style {
    font-style: italic;
    color: #5d6982;
}

2) Potom tu jsou vic okecavaci empty stavu: image

image

image

image

K tomu navrhuju obslouzit to komponentou vyse, rozsirenou o props <NotAvailable text="No Description"/>

3) zatim neresim ale nektery empty stavy jsou reseny obrazkama. Coz mi prijde dobry, ale zatim bych neobsluhoval touto komponentou image

4) zacal bych to teda prevlekat dle popisu vyse, je toho v aplikaci docela dost a je mozny ze budu zavadet jeste jinou property na rozliseni, pokud si neporadim nijak elegantneji.

ujovlado commented 5 years ago

Ideme tam teda davat novy rez len kvoli N/A? alebo na to kasleme?

janmichek commented 5 years ago

Ne, nedelal bych to. Myslim ze bohate staci ta prohlizecova emulace, nevypada to nijak zubate. Koukam na Chrome, FF, Edge

ujovlado commented 5 years ago

ok, super :)