search

keboola / indigo-ui

Indigo UI library, its CSS and React components. Also Styleguide app showing usages of this library.
https://indigo.keboola.com
MIT License
5 stars 0 forks source link

Search styles purge #259

Closed janmichek closed 5 years ago

janmichek commented 5 years ago

classy .kbc-search, .row-search, .kbc-search-row uz v kbc nikde nefiguruje Trash styles jsem trochu upravil a zchecknul viz comment ^^^

ujovlado commented 5 years ago

Vidim tam este nejake pouzitia v connection. Bol by si schopny poslat PR, ktory ten dummy/uvodny markup upravi?

https://github.com/search?q=org%3Akeboola+kbc-search&type=Code

janmichek commented 5 years ago

JJ, tady https://github.com/keboola/connection/pull/1533 Kde se vlastne zobrazi tenhle kod, kdyz uz v kbc je to po novym?

ujovlado commented 5 years ago

Kym sa nacita kbc-ui, tak je tam server render markup, ktory ti dava apache/php ... akonahle je uicko ready, tak sa to replacne.

Predstav si to nejako takto:

<div id="replace-me">
  some markup
</div>

ked je to ready, tak sa spravi document.getElementByID('#replace-me') a na nom sa da "replace" za UIcko ... t.j. vo vysledku tam "some markup" vidis len pocas nacitania za zaciatku

janmichek commented 5 years ago

@ujovlado Myslim ze tady taky nic nebrani nasazeni

ujovlado commented 5 years ago

ok, je to tam ... ja som na to "sral" lebo mi to nesvietilo medzi reviews ;)

janmichek commented 5 years ago

v pohode. Koukam ze je s tim review dasboardem nejakej prob. To uz je podruhy. Delam neco blbe?

ujovlado commented 5 years ago

Asi nie ... len vlastne to tu ostalo v stave "reviewer commented" ... aby to sa to opat dostalo do "inboxu" (https://github.com/pulls/review-requested) treba znovu poziadat o review. Ja teda obcas PRs kontrolujem, no k tomuto by som sa dostal povedzme koncom tyzdna.