keboola / indigo-ui

Indigo UI library, its CSS and React components. Also Styleguide app showing usages of this library.
https://indigo.keboola.com
MIT License
5 stars 0 forks source link

Move additional actions outside of a form #262

Closed ujovlado closed 5 years ago

ujovlado commented 5 years ago

Fixes #260

Fixuje to problem s tym, ze additional actions boli vnutri formulara. Tym padom bolo mozne pridat tam nieco, co by bolo nevalidne - napr. dalsi formular. Takisto by sa mohlo stat, ze niekto prida submit button a bude sa to spravat divne (ako napr. tu https://github.com/keboola/kbc-ui/commit/5fd6302424850ab14340e2e24090723a9e18b9d7)

ujovlado commented 5 years ago

Az to bude v produkcii, mozeme tie styles trosku upravit (toto podporuje obidve verzie markupu).

ujovlado commented 5 years ago

@janmichek kukol by si sa prosim na toto, nechcem to nehat vyhnit ;)

ujovlado commented 5 years ago

@natocTo skus spravit review tu. Malo by to znamenat:

ujovlado commented 5 years ago

Ak narazis na problemy s rozbehavanim -> https://github.com/keboola/indigo-ui/issues/265

ujovlado commented 5 years ago

Myslim, ze to tak povodne aj bolo pripravene, no zdalo sa mi to zbytocne, prave preto, ze sa to dalo ziskat z onChange.

Pri formulari s jednym inputom by to asi davalo zmysel, no snazil som sa to co najviac prisposobit kbc-ui, kde sa s tym imho prave pracovalo tak, ze ten state sa drzal mimo komponenty.

Asi to tam mozeme pridat (ked tak rozmyslam, asi to nebude ani BC break), no neviem, ci to uz teraz niecomu pomoze. Vlastne na par miestach by mohol zmiznut ten onChange.

Kaslal by som na to a pri prvej poziadavke na to, ze to treba to mozeme dorobit, ok?

natocTo commented 5 years ago

Ok. Třeba to nebude ani potřeba.

Já hned vidět v hlavě použití jako: (ale takové v kbc-ui asi není no)

<SearchBar onSubmit={() => console.log('co se vlastně hledá')} />
janmichek commented 5 years ago

@ujovlado Ode me tam mas review, mrkni.

ujovlado commented 5 years ago

@janmichek no asi to este musis submitnut :) nic nevidim

ujovlado commented 5 years ago

@natocTo na 2 miestach by sa to asi zislo. Chcem tym len povedat, ze ked som to spravil bez toho (moja chyba), nechajme to tak, kym nepride pouzitie, kde sa to hodi.

natocTo commented 5 years ago

Jasný. Ok.