keboola / indigo-ui

Indigo UI library, its CSS and React components. Also Styleguide app showing usages of this library.
https://indigo.keboola.com
MIT License
5 stars 0 forks source link

User link - focus bug #269

Closed ujovlado closed 6 years ago

ujovlado commented 6 years ago

screenshot_2018-09-18_20-28-15

janmichek commented 6 years ago

Zkusim to prozkoumat. Takhle na prvni oklikani jsem moc nezjistil.

ujovlado commented 6 years ago

Zreprodukovat to ide lahko, navigujes po stranke tabom alebo tak ako v screenshote ^

.nav>li>a:hover, .nav>li>a:focus {
    text-decoration: none;
    background-color: #fff;
}
janmichek commented 6 years ago

Je to videt uz na urovni samostatny komponenty - indiga https://indigo.keboola.com/?selectedKind=ExternalLink&selectedStory=ExternalLink&full=0&down=1&left=1&panelRight=0&downPanel=storybook%2Factions%2Factions-panel

Pravdepodobny reserni: https://stackoverflow.com/a/44410281/358804 Jdu ho vyzkouset.

ujovlado commented 6 years ago

Asi nerozumiem, ved tam je navyse len background-color

janmichek commented 6 years ago

Problem je ze tam zustane viset focus state, ktery by tam byt nemel. Budiz, klido to vyresim takhle, ale nevyresi to podstatu problemu. Pro me snadnejsi reseni. Jeste v tech focus stylech teda visi outline.

ujovlado commented 6 years ago

Problem je ze tam zustane viset focus state, ktery by tam byt nemel.

a nie je toto default chovanie browsera? preco by tam ten focus nemal ostat?

ujovlado commented 6 years ago

Do toho issue som to teda nenapisal - moja chyba, no myslel som, ze vieme o com sa bavime :)

janmichek commented 6 years ago

hm, dobra otazka. Zacal jsem to paralelne zkoumat. Je to tak jak pises, pripada mi to dost spis matouci. Myslel jsem ze nove otevreny tab ti vezme focus. Jdu fixnout ty styly.

janmichek commented 6 years ago

Mozne me zmatli i ten nazev issue. Zacal jsem resit Focus bug. Nicmene reseni v PR ^^^