Check if yarn link is working

keboola / indigo-ui

Indigo UI library, its CSS and React components. Also Styleguide app showing usages of this library.

https://indigo.keboola.com

MIT License

5 stars 0 forks source link

Check if yarn link is working #272

Closed ujovlado closed 5 years ago

ujovlado commented 5 years ago

Since kbc-ui has been heavily updated it is possible that it is not broken anymore.

If it's working, update readme with additional option (yarn link should be preferred)

natocTo commented 5 years ago

Včera jak jsem testoval tu Edit komponentu. Tak jsem používal "yarn link" a fungovalo mi to. Tak jen pro info.

janmichek commented 5 years ago

Ono to na 95% fungiruje, ale ma to nejaky bugy. Napriklad pri yarn linkovani nefunguje rozbalovani "Show more". Napriklad v modalu IM/OM. Kdyz se indigo nalinkuje z package tak to prob neni. Vetsinou jsem to hackoval tak ze jsem zkratka veril svymu kodu a delal to bez monosti vyzkouseni. xD

ujovlado commented 5 years ago

To sa mi nezda. Ak to mas dobre linknute, musi to ficat na 100% rovnako - ako keby si to mal z repository.

janmichek commented 5 years ago

Mam to linknuty podle navodu. Tobe tohle konkretni funguje?

ujovlado commented 5 years ago

Akurat to checkujem, vyzera, ze uz mi to fici. Predtym som to riesil cez yarn add, lebo vyzeralo ze webpack 1 mal problem so symlinkami.

ujovlado commented 5 years ago

Cez yarn add mi to ficalo identicky

janmichek commented 5 years ago

Zkusil jsem to jeste jednou prelinkovat ( po updatu yarnu ). ale porad mi to troli. Nemusime to resit, vim jak to obejit. Pripadne linkuju package.

Vypis po kliku na 'Show More'

ujovlado commented 5 years ago

Hm, divne ... a mas indigo buildnute?

ujovlado commented 5 years ago

No vyzera, ze sa to deje len vtedy ked mas v indigo-ui aj node_modules. Nemalo by to ale prekazat. Debugovat to ale zatial nejdem. Ja som to vzdy robil takto:

yarn build-lib
yarn rm -rf node_modules

^ a to som linkoval.