search

keboola / indigo-ui

Indigo UI library, its CSS and React components. Also Styleguide app showing usages of this library.
https://indigo.keboola.com
MIT License
5 stars 0 forks source link

Mobile sidebar css updates #288

Closed natocTo closed 5 years ago

natocTo commented 5 years ago

related: https://github.com/keboola/kbc-ui/pull/2099 wait: https://github.com/keboola/kbc-ui/pull/2143 wait: https://github.com/keboola/kbc-ui/pull/1996#issuecomment-420314876

Extrahování CSS z KBC-UI pro lepší mobilní zobrazení.

janmichek commented 5 years ago

Jeste tahle drobnost ^^^, jinak fajn. Potom jeste v connection pridat tu hlavicku. Kdybys nevedel jak, ozvi se.

natocTo commented 5 years ago

To asi budu potřebovat navést. Nevím kde (co je) connection. :)

janmichek commented 5 years ago

Aha, proto jsi se k tomu nehlasil xD Connection je core (nadrazena) aplikace kbc-ui je potom jeji UI. Je relativne tezky si ji rozjet lokalne, nicmene existuje nejaky minimal setup. Ja se o to tentokrat postaram, ale zaroven ti dam nejaky intro zitra.

janmichek commented 5 years ago

@ujovlado koukam ze uz mobilni hlavicka proudi do produkce, ted by to chtelo co nejdriv zacit restit toto. Vim ze to mas v queue .]

ujovlado commented 5 years ago

Uvidime az to regnem do connection :)

Halama commented 5 years ago

řeší to tohle https://github.com/keboola/connection/pull/1568#issuecomment-430222993 ?

ujovlado commented 5 years ago

To idem prave zistit

ujovlado commented 5 years ago

No, ked som si preniesil tie classnames do connection, vyzera, ze to este bude treba doladit, nemam tam navbar. Akoby nezafungovali tie meda queries csska.

screenshot_2018-10-16_16-35-40

ujovlado commented 5 years ago

screenshot_2018-10-16_16-36-41

ujovlado commented 5 years ago

Vidim problem v head.less

ujovlado commented 5 years ago

Skusim to hotfixnut, no predpokladam, ze tam narazim na dalsie veci.

ujovlado commented 5 years ago

Inac, nemalo to byt robene mobile first ked uz?

ujovlado commented 5 years ago

Lepsie :)

screenshot_2018-10-16_17-09-58

janmichek commented 5 years ago

@Halama hmm, s tim restartem orchestrace to asi nijak snadno nepujde. To mi nedoslo Budeme to muset jeste nejak vymyslet, jak na uzkym rozliseni zobrazovat ty akce vpravo. Takhle z fleku me nic nenapada ./ Mozna bude lepsi to revertnout, nevim

janmichek commented 5 years ago

Ty akce vedle breadcrumbs navigace jsou nesikovny. Zkusim vymyslet nejaky hotfix, tak aby se to zalamovalo pod sebe. Ony ty akce na pravy strane navigace jsou na vice mistech