search

keboola / indigo-ui

Indigo UI library, its CSS and React components. Also Styleguide app showing usages of this library.
https://indigo.keboola.com
MIT License
5 stars 0 forks source link

JobStatus component migration #316

Closed janmichek closed 5 years ago

janmichek commented 5 years ago

Jeste to potrebuju projit a vyscreenovat

janmichek commented 5 years ago

Dava mi smysl spojit to s timto, protoze to sdili tu barevnou mapu https://github.com/keboola/kbc-ui/blob/fcae49f542550e14c46bf3a6a86687c91e41373b/src/scripts/react/common/JobStatusLabel.jsx#L18

a pomoci props rict zda vyrenderovat textovy label nebo kolecko

natocTo commented 5 years ago

Jinak to spojení je asi fajn. Nebo by šlo něco jako má třeba Modal v react-bootstrap (Modal.Header apod.) Tak JobStatus.Circle atd, ale to je asi zbytečné a jedna props to v pohodě obslouží.

janmichek commented 5 years ago

Jasne, diky upravim. JobStatus.Circle - me se tyhle zapisy libi. Nasel jsem jen jedinou nevyhodu, ze se to hur generuje v cyklu. Potom uz ten zapis neni tak svezi.

ujovlado commented 5 years ago

Suhlasim s tym, ze zatial to riesit ako JobStatus.Circle netreba.

janmichek commented 5 years ago

Upraveno, uz to nehazi undefined classu pri zadnym/spatnym statusu Pridal jsem test a snapshot.

janmichek commented 5 years ago

Diky, pro cistotu jsem upravil

ujovlado commented 5 years ago

To zvacsenie ikony na 19px sa mi nezda, dam tam standard ako je vsade a uvidime.