Check if outer-pages.less can be removed

keboola / indigo-ui

Indigo UI library, its CSS and React components. Also Styleguide app showing usages of this library.

https://indigo.keboola.com

MIT License

5 stars 0 forks source link

Check if outer-pages.less can be removed #393

Closed ujovlado closed 5 years ago

ujovlado commented 5 years ago

Related: #391

[x] .kbc-outer-page https://github.com/search?q=org%3Akeboola+kbc-outer-page&type=Code .. uz le try-keboola-com, co nie je issue.
[x] .kbc-error-page https://github.com/search?q=org%3Akeboola+kbc-error-page&type=Code
[x] .kbc-projects-list https://github.com/search?q=org%3Akeboola+kbc-projects-list&type=Code
[x] .dropdown-header duplicita https://github.com/keboola/indigo-ui/blob/4c7621bc8bf02bc37e756ad96db03a1f7e0d0262/src/indigo/less/sidebar.less#L79

natocTo commented 5 years ago

Jak jsme psal tak .kbc-outer-page není v KBC-UI nikde. Tak pokud to není na connection někde, tak se celá ta sekce může také vyhodit.

natocTo commented 5 years ago

kbc-error-page také v KBC-UI nedohledám, tak asi nemáme

natocTo commented 5 years ago

To samé platí pro kbc-projects-list.

natocTo commented 5 years ago

Pak už tam zbude jen jedna věc dropdown-header, která je použita v ProjectSelect (staré UI), to pak půjde asi vyhodit až budeme mít menu nahoře. Tam to pak musím stylovat znovu tak či tak.

ujovlado commented 5 years ago

Projects-list tam este stale je myslim: https://github.com/search?q=org%3Akeboola+kbc-projects-list&type=Code

ujovlado commented 5 years ago

^ ale to este kuknem, nejako sa mi to nezda.

ujovlado commented 5 years ago

jo, tak tam je to ID ;) ... super

ujovlado commented 5 years ago

Asi aj ten dropdown-header:

https://github.com/keboola/indigo-ui/blob/4c7621bc8bf02bc37e756ad96db03a1f7e0d0262/src/indigo/less/sidebar.less#L79

ujovlado commented 5 years ago

Takze si sa nakoniec trafil :)