search

keboola / indigo-ui

Indigo UI library, its CSS and React components. Also Styleguide app showing usages of this library.
https://indigo.keboola.com
MIT License
5 stars 0 forks source link

Idea: Split to 2 (or 3) packages (within this repo) #68

Closed ujovlado closed 6 years ago

ujovlado commented 6 years ago

We can split the code to 2 parts/packages. For example using lerna.

  1. indigo-ui library itself (what is published to npm) + storybook
  2. part for building dist css (what is registered to connection) ... this will include 1.

or to 3 packages, where storybook can be also in separate part (will also include 1., of course w/o storybook)

Idea behind this is to make it more stable (e.g. to have an option release new indigo-ui version without publishing CSS to connection).

ujovlado commented 6 years ago

For now, it'll be enough to extract part which is generating/registering css to KBC.

Here's the repo: https://github.com/keboola/indigo-ui-kbc

pivnicek commented 6 years ago

I like the 3 packages version :-)

ujovlado commented 6 years ago

Toto postuchnem viac, sere ma, ze pridanim novej komponenty (co je vlastne cisty javascrit) sa releasuju/reguju csska do Connection.

janmichek commented 6 years ago

Tohle nedokazu posoudit / zmerit, co se bude kompilovat rychleji. Souhlas ze Storybook muze byt vedlejsi repo, pokud to brzdi

ujovlado commented 6 years ago

Chvilku som sa vrtal v tom indigo-ui-kbc, kde som chcel odfajcit zbytocne veci, no stale sa mi to moc nepozdava - pre lokalne otestovanie by sa zhorsilo developer experience ... a tak idem asi vyskusat tu lernu.

janmichek commented 6 years ago

jj koukal jsem ze tam neco kutis, zatim ti asi moc neporadim. Kdybys potreboval neco testnout, dej vedet .]

ujovlado commented 6 years ago

Tak som sa bavil s lerna, vyzera to dobre, este by som to nechal chvilku ulezat a potom by som to rozbil na samostatne packages. Zacal by som storybookom.

To repo indigo-ui-kbc zmazem, nebude to uz treba

ujovlado commented 6 years ago

Tak predsalen som to prehodil :) nakoniec sa to pouzuje cisto na deployment, takze to nic neovplyvni.

ujovlado commented 6 years ago

Toto tu zavrem, tym, ze vzniklo to separatne repo, releasov tu sa uz az tak nebudeme musiet bat a trosku sa to uvolni - t.j. posraty release indigo-ui nerozbije connection pokial sa nespravi deploy indigo-ui-kbc.