search

keeganwitt / gmock

Automatically exported from code.google.com/p/gmock
6 stars 2 forks source link

Improve the method signature shown in the error message #19

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
It should be
    'put("bar",1)'
instead of
    'put(bar,1)'

Invoke inspect() on each parameter.

Original issue reported on code.google.com by JohnnyJianHY on 14 Oct 2008 at 3:15

GoogleCodeExporter commented 9 years ago 
Accepted or not?

Original comment by JohnnyJianHY on 16 Oct 2008 at 1:03

GoogleCodeExporter commented 9 years ago 
Yes that sound like a good idea. We are talking about String where we should 
had the
quote right?

Original comment by julien.g...@gmail.com on 16 Oct 2008 at 5:36

GoogleCodeExporter commented 9 years ago 
Yes, and also something else. You can read the source code of inspect().

What's more, should it add a space after the comma? Like:
    put("bar", 1, [true, 1])

Original comment by JohnnyJianHY on 17 Oct 2008 at 9:32

GoogleCodeExporter commented 9 years ago 
Ok for the space. I thought it was already here.

Had a look at inspect: sound good to me.

Original comment by julien.g...@gmail.com on 17 Oct 2008 at 3:32

GoogleCodeExporter commented 9 years ago

Original comment by JohnnyJianHY on 19 Oct 2008 at 3:04

GoogleCodeExporter commented 9 years ago

Original comment by JohnnyJianHY on 19 Oct 2008 at 4:11