search

keeganwitt / gmock

Automatically exported from code.google.com/p/gmock
6 stars 2 forks source link

Property method 'sets' is not intuitive #30

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
We should probably rename 'sets' to 'set' in the property setting. People
I've seen using it have found it counter intuitive (and not correct
English). We should deprecated sets for the time being to help people
migrating.

Original issue reported on code.google.com by julien.g...@gmail.com on 25 Nov 2008 at 7:37

GoogleCodeExporter commented 9 years ago

Original comment by julien.g...@gmail.com on 25 Nov 2008 at 7:37

GoogleCodeExporter commented 9 years ago 
What do you mean by "deprecated"? You mean we should rename 'sets' to 'set', 
or, 
keep both of them and mark 'sets' deprecated?

Original comment by JohnnyJianHY on 25 Nov 2008 at 7:52

GoogleCodeExporter commented 9 years ago 
I think we should keep sets for the next release or two and mark it has 
deprecated -
or throw an exception. And then remove it.

Original comment by julien.g...@gmail.com on 25 Nov 2008 at 8:43

GoogleCodeExporter commented 9 years ago 
OK, let's throw a groovy.lang.DeprecationException.

Original comment by JohnnyJianHY on 25 Nov 2008 at 9:00

GoogleCodeExporter commented 9 years ago 
But what about 'raises' and 'returns'? Are they correct English? Sorry that I 
am not 
good at English grammars.

Original comment by JohnnyJianHY on 25 Nov 2008 at 1:04

GoogleCodeExporter commented 9 years ago 
That would be a great change. I found 'sets' quite strange, whereas 'raises' and
'returns' are fine.

Original comment by james.co...@gmail.com on 26 Nov 2008 at 9:46

GoogleCodeExporter commented 9 years ago

Original comment by JohnnyJianHY on 26 Nov 2008 at 11:26

GoogleCodeExporter commented 9 years ago

Original comment by JohnnyJianHY on 26 Nov 2008 at 11:57