keflavich / imf

Simple tools to work with the Initial Mass Function
MIT License
44 stars 17 forks source link

Refactor - make mmin/mmax immutable #28

Closed keflavich closed 3 years ago

keflavich commented 3 years ago

This is a big refactor to make mmin/mmax immutable and make the whole package more pythonic.

In this process, I caught a couple edge-case errors, and I found that the Schecter functions were broken. A future step is to add truncated Power Law distributions to distributions.py to fix that.

@segasai can you review?

segasai commented 3 years ago

Sure. Let me take a look over next day or two.

keflavich commented 3 years ago

Alright, let me know when something inevitably breaks... and let's add more tests! If you have any examples you want to add to the test suite, I think it'll be helpful.