keijiro / Kino

A collection of custom post processing effects for Unity
2.1k stars 149 forks source link

Isoline view range #6

Closed zeekindustries closed 5 years ago

zeekindustries commented 5 years ago

Hey Keijiro!

I wanted to know if there's a way to limit the range of where the isoline starts/finish drawing, I found that the range is given by the camera near/far plane, and tried to modify the ComputeViewSpacePosition in DepthUtils.hlsl but with no success on trying to remap the z buffer. Was trying to get the isoline grow away from the camera based on some value. Would be great if this feature existed. Thanks a lot! Awesome work as always.

keijiro commented 5 years ago

The Isoline effect is removed in the recent update to reduce the cost of maintenance.

andybak commented 5 years ago

Would Isoline be particularly tricky to implement on HDRP? I was actually going to have a stab at it myself.

(EDIT - corrected URP to HDRP)

keijiro commented 5 years ago

Actually not so tricky. It's just hard to maintain things with HDRP due to its forward-compatibility breaking nature.